On Wed, May 22, 2024 at 10:40 AM Poul-Henning Kamp <p...@phk.freebsd.dk> wrote: > > -------- > Dridi Boukelmoune writes: > > > > Yes, but what do we need that for ? > > > > We don't, I'm working in a VMOD that computes hashes of regular files > > among other things. This looked like generic code not specific to that > > VMOD. > > Is it a VMOD you expect to be adopted into the tree, and if so, could > you say a bit more about it ?
This is for a third-party VMOD. > If it is an out-of-tree VMOD, I'm not very keen on adding library > functions just for one VMOD (but can probably be persuaded if the > functions are tied to Varnish through data structures etc.) > > This specific suggestion does not meet that threshold, and we would > also have to add an explicit test-case for gcov, so I really dont > see much benefit ? The goal was to offer convenience, but this code is trivial to embed. Dridi _______________________________________________ varnish-dev mailing list varnish-dev@varnish-cache.org https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
