On Tue, Jun 22, 2010 at 09:29:24AM +0200, Christian Pötzsch wrote: > On 06/22/10 00:35, Life is hard, and then you die wrote: > > As an aside, I've tried to figure out what the prevailing coding style > > is and follow it, but especially when it comes to tabs/spaces and > > indentation it wasn't always clear; it would be helpful if there were a > > basic style guide on the wiki or something (and if the code consistently > > followed it). > The coding style guide is located in doc/VBox-CodingGuidelines.cpp.
Ah, missed that - thanks! Hmm, there are several things I didn't find in there: - tabs vs spaces (yes, you answered that below, but shouldn't that be in the doc too?) - indent (same comment as above) - bracing style (seems to be ANSI-style, according to the examples and the majority of code) - max line length (80 chars?) - indentation of wrapped lines - I've seen both fixed, 4 char indentation as well as align with paren in previous line. > No tabs, 4 spaces indentation. Not all the source code follow this strictly > yet, but it is improving. Ok. The vast majority of lines in the source files I edited were of the tab variety, and hence that's what I used - I can easily redo the patches to use spaces on all the affected lines, if you'd like. Would you like a patch that first fixes all the tabs, indentation, and bracing? (just for .../solaris/SharedFolders/). Cheers, Ronald _______________________________________________ vbox-dev mailing list [email protected] http://vbox.innotek.de/mailman/listinfo/vbox-dev
