On Wed, 2010-06-23 at 04:51 -0700, Life is hard, and then you die wrote: > Ok, makes sense. I took a closer look at the Solaris coding standards > guide and realized I got a couple things wrong (mainly > line-continuations and switch statements); so I reworked the patches > to follows those better. > > Also, while looking at the latest linux shared-folders changes today I > realized that I had fallen into the same trap with the readdir fix > (patch 06) as the linux code (http://www.virtualbox.org/ticket/5251), > i.e. it wasn't properly resetting the directory listing for apps doing > a seekdir. I've fixed that now and tested it, both using the 'svnadmin > load' mentioned in the above ticket as well as with a small test-suite > I wrote for this. > > Attached therefore you'll find a new set of patches which include both > the style fixes and the readdir fix, but are otherwise identical to > the previous ones. > > > I'll take a look at the patches you provided and get back to you > > regarding them. Thanks a lot for the effort and time on this. > > Thanks.
Great! Thanks for the quick fixes. I've begun reviewing & committing your patches. Since these patches are significant, I'll mentioned your name as "Ronald" (no mail address included) as a contributor in the source files involved, I hope this is agreeable. If you don't want to be mentioned for some reason let me know. I will mail you here once I complete reviewing, committing and testing these patches. Thanks & Regards, Ram. > > Cheers, > > Ronald > > _______________________________________________ > vbox-dev mailing list > [email protected] > http://vbox.innotek.de/mailman/listinfo/vbox-dev _______________________________________________ vbox-dev mailing list [email protected] http://vbox.innotek.de/mailman/listinfo/vbox-dev
