On Sat, 2019-05-04 at 21:51 +0200, Knut St. Osmundsen wrote: > On 2019-05-04 7:44 PM, Michael Thayer wrote: > > 04.05.19 16:44, Michael Thayer wrote: > > > 03.05.19 23:40, Knut St. Osmundsen wrote: > > > [...] > > > > Finally, does the libc or kernel mount() implementation somehow > > > > invoke > > > > the /sbin/mount.vboxsf helper tool? Please point me to the > > > > code causing > > > > this, because our vboxsf sources does not parse any parameter > > > > strings, > > > > it is binary struct only. > > > The mount(8) manual page reads to me that the mount utility calls > > > the > > > mount helper (or skips it if you pass "-i"). Our mount helper > > > calls > > > mount(2) to perform the actual mount. Hans modified the shared > > > folder > > > kernel code to do the parsing. I suspect the version Sérgio is > > > testing > > > against has that change as a patch. Sérgio, could you take a > > > look at > > > that, or point us to the sources you tested against? > > Attaching Hans's patch to the kernel driver. This version is from > > a > > while back, don't know if it will still apply cleanly. > > I see, the patch fro Sérgio presupposes Hans' patch, so forget my > question about how mount(2) could magically involve the > /sbin/mount.vboxsf helper, it won't. > > The match_token code that Hans' patch depends on seems to have been > introduced in 2.6.0, so we'd have to emulate that for older kernels, > or > do manual option parsing. It would make mount option handling > somewhat > more straight forward, provided it will work for older kernels too. > > Currently busy with shared folders on windows, so this will have to > wait > till I'm back on linux against. > > Cheers, bird.
Adding Hans to thread AFAIK with this patch we don't need /sbin/mount.vboxsf helper tool mount -t vboxsf works and we will autoload vboxsf.ko , i.e we don't need modprobe vboxsf at boot anymore Note: I haven't read all tread carefully , I will read it Monday. Best regards, > > _______________________________________________ > vbox-dev mailing list > vbox-dev@virtualbox.org > https://www.virtualbox.org/mailman/listinfo/vbox-dev -- Sérgio M. B. _______________________________________________ vbox-dev mailing list vbox-dev@virtualbox.org https://www.virtualbox.org/mailman/listinfo/vbox-dev