Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#738120 - Logging in OOP.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/processPool.py
Line 293: pass # Nothing we can do
Line 294:
Line 295: # Add logger handler (via Queue)
Line 296: hdlr = QueueHandler(logQueue)
Line 297: hdlr.setLevel(logging.DEBUG)
it would be nicer to inherit log level from main vdsm
Line 298: formatter = logging.Formatter("%(asctime)s %(filename)s,
%(lineno)d, %(funcName)s: %(message)s")
Line 299: hdlr.setFormatter(formatter)
Line 300: logging.root.addHandler(hdlr)
Line 301:
Line 294:
Line 295: # Add logger handler (via Queue)
Line 296: hdlr = QueueHandler(logQueue)
Line 297: hdlr.setLevel(logging.DEBUG)
Line 298: formatter = logging.Formatter("%(asctime)s %(filename)s,
%(lineno)d, %(funcName)s: %(message)s")
same goes to formatter - more polite to take the configurable one from main
process. However we must log pid too, or the lines of unrelated oops would mix.
Line 299: hdlr.setFormatter(formatter)
Line 300: logging.root.addHandler(hdlr)
Line 301:
Line 302: poller = select.poll()
--
To view, visit http://gerrit.usersys.redhat.com/985
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe8abf31f46469e3c6fdac670f0ff03fe9cefe8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
