Saggi Mizrahi has posted comments on this change.
Change subject: Related to BZ#738120 - Logging in OOP.
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Minor issues. Good job BTW. It's been a long time coming
....................................................
File vdsm/storage/processPool.py
Line 126: if helper is None:
Line 127: helper = Helper(self._logQueue)
Line 128: self._helperPool[i] = helper
Line 129:
Line 130: kwargs['loggingThreadName'] =
threading.current_thread().name
Put the var name in constant
Line 131: helper.pipe.send((func, args, kwargs))
Line 132: if not helper.pipe.poll(self.timeout):
Line 133: helper.interrupt()
Line 134: if not helper.pipe.poll(self._gracePeriod):
Line 264: if fd == lifeLine or event in (select.EPOLLHUP,
select.EPOLLERR):
Line 265: return
Line 266:
Line 267: func, args, kwargs = pipe.recv()
Line 268:
threading.current_thread().setName(kwargs['loggingThreadName'])
Pad the var with __ so its well known it's not a regular arg
Line 269: kwargs.pop('loggingThreadName')
Line 270: res = err = None
Line 271: try:
Line 272: res = func(*args, **kwargs)
--
To view, visit http://gerrit.usersys.redhat.com/985
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe8abf31f46469e3c6fdac670f0ff03fe9cefe8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Naori <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
