Yotam Oron has posted comments on this change.

Change subject: vds_bootstrap: fix usage string
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 909:     -u {true|false} -- use rhev-m-deployed yum repo
Line 910:     -f              -- override firewall rules by default ovirt rules.
Line 911: obsolete options:
Line 912:     -n <netconsole_host:port>
Line 913:     -r <rev_num>
I guess a better way to do it would have been to use the Python command line 
parser thing we use.
Line 914:     """
Line 915:     try:
Line 916:         rev_num = None
Line 917:         orgName = 'Red Hat Inc.'


Line 926:                 orgName = v
Line 927:             if o == "-t":
Line 928:                 systime = v
Line 929:             if o == "-n":
Line 930:                 # TODO: remove me as soon as possible (BZ#689726)
BZ#689726 is verified, I guess this netconsole genius can be gone for good.
Line 931:                 pass
Line 932:             if o == "-u":
Line 933:                 usevdcrepo = (v.upper() == 'TRUE')
Line 934:             elif o == '-f':


--
To view, visit http://gerrit.usersys.redhat.com/982
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8950764778dc61d04caeed4c74e792d52bba3378
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Yotam Oron <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to