Igor Lvovsky has posted comments on this change.
Change subject: BZ#741203 Don't return a value in domain selftest
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1292: 'masterValidate' : { 'mount' : False, 'valid' :
False }
Line 1293: }
Line 1294: code = 0
Line 1295: try:
Line 1296: domain.selftest()
I think we don't want to raise exception here. This is a repoStats thread that
run for every active domain and we want just to return error exit code but not
raise exceptions
Line 1297:
Line 1298: res = domain.getStats()
Line 1299: stats.update(res)
Line 1300: # Add here more selftests if needed
--
To view, visit http://gerrit.usersys.redhat.com/1012
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
