Federico Simoncelli has posted comments on this change. Change subject: BZ#741203 Don't return a value in domain selftest ......................................................................
Patch Set 2: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2011-10-07 16:26:09 +0000 Line 4: Commit: Federico Simoncelli <[email protected]> Line 5: CommitDate: 2011-10-12 16:21:31 +0000 Line 6: Line 7: BZ#741203 Don't return a value in domain selftest The fix for bz741203 modifies the selftest methods and is based on this patch. Line 8: Line 9: The domain selftest doesn't need to return a boolean value, if the check Line 10: fails an exception is raised. Line 11: .................................................... File vdsm/storage/sd.py Line 351: Line 352: def selftest(self): Line 353: """ Line 354: Run internal self test Line 355: """ Thanks. Line 356: Line 357: def upgrade(self, targetVersion): Line 358: """ Line 359: Upgrade the domain to more advance version .................................................... File vdsm/storage/sp.py Line 1303: stats['masterValidate'] = domain.validateMaster() Line 1304: except se.StorageException, e: Line 1305: code = e.code Line 1306: except (OSError, Timeout): Line 1307: code = se.StorageDomainAccessError.code No need for this here, this is already done in StatsThread.run(). Line 1308: Line 1309: return stats, code Line 1310: Line 1311: -- To view, visit http://gerrit.usersys.redhat.com/1012 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I551970c1f426f2b28ad58e49310338de6b40a29f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
