Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] Use vdsm-tool to set libvirt password
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm-tool/sudoers.py
Line 26: SUDOERS_LOCK = "/etc/sudoers.tmp"
Line 27: 
Line 28: LIBVIRTPASS_DEFAULT = "shibboleth"
Line 29: LIBVIRTPASS_FILE = "/etc/pki/vdsm/keys/libvirt_password"
Line 30: LIBVIRTAUTH_FILE = "/etc/libvirt/passwd.db"
leftovers?
Line 31: 
Line 32: PATTERN_INCLUDEDIR = "^#includedir\s+/etc/sudoers.d"
Line 33: PATTERN_VDSMFILE = "^#include\s+/etc/sudoers.d/50_vdsm"
Line 34: 


....................................................
File vdsm-tool/vdsm-tool
Line 34:         "adjust sudoers file for vdsm"
Line 35:     ),
Line 36:     'install-libvirtpass': (
Line 37:         vdsmtool.libvirt.install_libvirtpass,
Line 38:         "add a password to access libvirt"
via sasl
Line 39:     ),
Line 40: }
Line 41: 
Line 42: def usage_and_exit(exit_code):


--
To view, visit http://gerrit.usersys.redhat.com/921
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I952fe699f0110d173f0941713560125654edeac5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to