Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add the vdsm-tool command
......................................................................
Patch Set 1: (6 inline comments)
....................................................
File vdsm.spec.in
Line -3
Line -2
Line -1
Line 0
Line 1: %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
any reason not to use %{py_sitedir} from %{_rpmconfigdir}/macros.python?
Line 2:
Line 3: %define vdsm_reg vdsm-reg
Line 4: %define vdsm_name vdsm
Line 5: %define vdsm_bootstrap vdsm-bootstrap
....................................................
File vdsm-tool/Makefile.am
Line -3
Line -2
Line -1
Line 0
Line 1: # Copyright 2008 Red Hat, Inc. and/or its affiliates.
look at your calendar ;-)
Line 2: #
Line 3: # Licensed to you under the GNU General Public License as published by
Line 4: # the Free Software Foundation; either version 2 of the License, or
Line 5: # (at your option) any later version. See the files README and
Line 2: #
Line 3: # Licensed to you under the GNU General Public License as published by
Line 4: # the Free Software Foundation; either version 2 of the License, or
Line 5: # (at your option) any later version. See the files README and
Line 6: # LICENSE_GPL_v2 which accompany this distribution.
long dead file
Line 7: #
Line 8:
Line 9: dist_sbin_SCRIPTS = \
Line 10: vdsm-tool
Line 9: dist_sbin_SCRIPTS = \
Line 10: vdsm-tool
Line 11:
Line 12: dist_vdsmtool_DATA = \
Line 13: __init__.py
tab inconsistency
Line 14
Line 15
Line 16
Line 17
....................................................
File vdsm-tool/vdsm-tool
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: VDSM_TOOL_PATH = "/usr/share/vdsm-tool"
is it ever needed?
Line 22:
Line 23: import os
Line 24: import sys
Line 25: import getopt
Line 23: import os
Line 24: import sys
Line 25: import getopt
Line 26:
Line 27: # VDSM Tool imports should go here
nitpicking: it would be nicer to define an empty commands dict in this patch.
Line 28:
Line 29: def usage_and_exit(exit_code):
Line 30: print "Usage: %s [options] <command>\n" % sys.argv[0]
Line 31:
--
To view, visit http://gerrit.usersys.redhat.com/1009
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
