Federico Simoncelli has posted comments on this change. Change subject: Fix: HSM should not write metadata (*BlkSize) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 249: self.logBlkSize, self.phyBlkSize = 512 This bug is really horrible! Anyway this patch is going to fail (syntax error). I believe you can safely use lvm.getVGBlockSizes(sdUUID) to get the block size. In the future we must remove the try/except and let it fail if the meta param is missing. Anyway we should find a place where to initialize these parameters when they are missing. -- To view, visit http://gerrit.ovirt.org/201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96fdbc69071d014c7443abce61f7601ea593a378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
