Federico Simoncelli has posted comments on this change. Change subject: Fix: HSM should not write metadata (*BlkSize) ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/blockSD.py Line 248: # 512 by Saggi "Trust me (Smoch Alai (sic))" What if an old domain (without the keys) is cloned to a 4K bs device? It will be treated as a 512 bs device and we should hope that it will fail for some reason before corrupting anything. Using lvm.getVGBlockSizes would not make it better though. -- To view, visit http://gerrit.ovirt.org/201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96fdbc69071d014c7443abce61f7601ea593a378 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
