Dan Kenigsberg has posted comments on this change. Change subject: Add NoIntr utility class ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/misc.py Line 1296: func_args = [self._getArgValue(x) for x in args] I find this mechanism a bit cumbersome, and would not work well for system call with multiple arguments. did you consider having the arg translator class take all the args of the original syscall? -- To view, visit http://gerrit.ovirt.org/199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8cd7f2c6ef8c4845fca617a0423b922fc81cf0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
