Federico Simoncelli has posted comments on this change. Change subject: Add NoIntr utility class ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/storage/misc.py Line 1296: func_args = [self._getArgValue(x) for x in args] Having a translator that takes all the args means more or less that you need a translator for each syscall you want to use. With "would not work well" you mean that it would take O(n) to check and translate the args into a new list? I would be concerned if we're expecting to receive thousands of interrupt per second. An O(n) of hasattr with n (usually much) < 10 is not scary. -- To view, visit http://gerrit.ovirt.org/199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8cd7f2c6ef8c4845fca617a0423b922fc81cf0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
