Federico Simoncelli has posted comments on this change.
Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File vdsm_hooks/persist-vdsm-hooks
Line 9: . /usr/libexec/vdsm/vdsm-bash-fucntions
Macro. You probably need to rename the file (.in) and include it in the right
sections in Makefile.am.
....................................................
File vdsm/storage/misc.py
Line 1298: OVIRT_NODE = os.path.exists('/etc/ovirt-node-image-release')
This is going to be executed only if the first os.path.exists raises an
exceptions and not when it just returns False.
....................................................
File vdsm/vdsmd.in
Line 24: . /usr/libexec/vdsm/vdsm-bash-functions
Use the macro here too.
Line 285: if isOvirt && [ ! -f /etc/pki/vdsm/certs/vdsmcert.pem ]
If a macro wasn't used here, we should.
....................................................
File vdsm/vdsm-store-net-config.in
Line 6: . /usr/libexec/vdsm/vdsm-bash-functions
I believe we have a macro for the libexec vdsm path.
--
To view, visit http://gerrit.ovirt.org/268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
