Dan Kenigsberg has posted comments on this change. Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 7: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine linefeed missing before Change-Id .................................................... File vdsm_reg/vdsm-reg-setup Line 47: # Set the registration URL accordingly with the hypervisor finding the correct path seems like a job for a separate function, and certainly in another patch. but why do you need RHEVManagerWeb for 2.x host? note that such a host would still need to connect to an upstream ovirt-engine -- To view, visit http://gerrit.ovirt.org/268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
