Dan Kenigsberg has posted comments on this change.
Change subject: BZ#753625 honor displayNetwork again
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File vdsm/clientIF.py
Line 114: self._createLibvirtNetwork()
Networks
Line 146: def _createLibvirtNetwork(self):
"""docstring explaining that this function is mostly for upgrade from versions
that did not have a libvirt network per vdsm network"""
Line 150: lvNetwork = '%s%s' % (configNetwork.NETPREFIX, network)
hmmm, that's a cumbersome way to write
configNetwork.NETPREFIX + network
Line 151: if not lvNetwork in lvNetworks:
didn't we agree that the net creation logic should not be repeated here and in
configNetwork?
....................................................
File vdsm/configNetwork.py
Line 587: logger = logging.getLogger("delNetwork")
why do you bother to create a new logger for a single line?
I'd use logging.debug() istead
--
To view, visit http://gerrit.ovirt.org/255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia403496b2df9800ad027b0bab48f4eed4e75c2de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
