Dan Kenigsberg has posted comments on this change.
Change subject: BZ#753625 honor displayNetwork again
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Many thanks, Shahar, for your work on this - few little changes, though.
Also, if you've asked pre-integ to verify the fix, let us wait for their tick.
....................................................
File vdsm/configNetwork.py
Line 578: netName = '%s%s' % (NETPREFIX, bridge)
+ fits here, too.
....................................................
File vdsm/libvirtvm.py
Line 932: listen.setAttribute('network', '%s%s' %
(configNetwork.NETPREFIX, self.conf.get('displayNetwork')))
+ is simpler
(and it's hard for me to review lines longer than 80 chars.)
--
To view, visit http://gerrit.ovirt.org/255
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia403496b2df9800ad027b0bab48f4eed4e75c2de
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
