Federico Simoncelli has posted comments on this change.
Change subject: fix faqemu for fedora host
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File configure.ac
Line 116: vdsm_hooks/faqemu/vdsm-faqemu
Just to limit the files here... can't we import the vdsm constants
(sys.path.append) and define the path there (eg: EXT_QEMU, EXT_QEMU_KVM?).
....................................................
File vdsm_hooks/faqemu/before_vm_start.py
Line 45: emulatorPath =
domxml.createTextNode('/usr/libexec/vdsm/vdsm-faqemu')
We should change the path here if you opt for the bin path.
....................................................
File vdsm_hooks/faqemu/Makefile.am
Line 9: dist_noinst_SCRIPTS = \
If we decide to place it in /usr/bin (fedora alike) we could just use
dist_bin_SCRIPTS and drop the manual install below.
--
To view, visit http://gerrit.ovirt.org/324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8efc37c9dd63b482a7791f64e27fd864f303d4c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
