Dan Kenigsberg has posted comments on this change.
Change subject: fix faqemu for fedora host
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm_hooks/faqemu/before_vm_start.py
Line 45: emulatorPath =
domxml.createTextNode('/usr/libexec/vdsm/vdsm-faqemu')
I don't like to put it in /usr/bin... I suppose it would have been nicer to
make autoconf macro-edit this path, but I would very much ask to postpone such
a change for a future patch. I just want to make faqemu working on Fedora.
....................................................
File vdsm_hooks/faqemu/Makefile.am
Line 9: dist_noinst_SCRIPTS = \
I do not think that it makes sense to make it user-executable.
/usr/libexec is its place
--
To view, visit http://gerrit.ovirt.org/324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8efc37c9dd63b482a7791f64e27fd864f303d4c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
