Ayal Baron has posted comments on this change. Change subject: vds_boostrap: rename rhevm to engine ......................................................................
Patch Set 2: I would prefer that you didn't submit this "engine" is a lousy non descriptive name for the bridge and it's not clear who is using it. bridge name should either be vdsm or something like virt In addition, it is not at all clear to me why ovirt relies on a specific name for the bridge being present. vdsm should just mark the bridge used to communicate with backend or something. -- To view, visit http://gerrit.ovirt.org/311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
