Dan Kenigsberg has posted comments on this change.
Change subject: rename rhevm bridge to brVDSM
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(6 inline comments)
....................................................
File vdsm_reg/config.py.in
Line 34: config.set('vars', 'vdc_authkeys_path', '/@[email protected]')
huh? this makes no sense. this should probably change to "engine", as this is
ovirt-engine's path.
Hmmm. it seems that no one is even using this configurable... Please verify the
utter removal is more sensible.
....................................................
File vdsm_reg/deployUtil.py.in
Line 87: REMOTE_SSH_KEY_FILE = "/@[email protected]"
this one IS used, and I would guess that this would have to remain.
we may need another constant for this name - depending on the location in
Engine - /brVdsm.ssh.key.txt makes no sense.
Line 347: logging.debug("Bridge @vdsmbridge@ already exists.")
Here we have a local variable MGT_BRIDGE_NAME, let's use it instead of ac macro
games.
Line 559: if key != '\n' and not key.endswith("== @vdsmbridge@") or
key.startswith("#"):
here "rhevm" is not the name of the bridge, but the name of the key owner. We
should write the line with "ovirt-engine" in the end, not brVDSM.
Line 1383: vdsmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
too brutal sed here! this is the engine's cert, not vdsm's.
....................................................
File vdsm_reg/vdsm-reg.conf.in
Line 15: vdc_authkeys_path=/@[email protected]
I believe this should die die die, but please recheck.
--
To view, visit http://gerrit.ovirt.org/311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c98658af80ad52a14934a962be4945c91ff48d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Chris Wright <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
