Dan Kenigsberg has posted comments on this change.
Change subject: Set drive's name during Drive initialization
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
minor question
....................................................
File vdsm/libvirtvm.py
Line 770: target.setAttribute('dev', drive.libvirtName())
I think you suggested that it does not make sense to calculate this twice; use
drive.name instead?
--
To view, visit http://gerrit.ovirt.org/408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b3d93ddb8fbf81ff98e90ab96fc9a16bac94644
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
