Federico Simoncelli has posted comments on this change. Change subject: Set drive's name during Drive initialization ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/vm.py Line 65: def libvirtName(self): Since this became an internal utility function we could make it private. This will also prevent other patches to call this old method by mistake (eg: my patches :-). -- To view, visit http://gerrit.ovirt.org/408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b3d93ddb8fbf81ff98e90ab96fc9a16bac94644 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
