Dan Kenigsberg has posted comments on this change. Change subject: Clean up the config.py format ......................................................................
Patch Set 4: I would prefer that you didn't submit this (2 inline comments) minor suggestion .................................................... File vdsm/config.py.in Line 236: for i in parameters: maybe for section, keylist in parameters: slightly more pythonic and readable. Line 238: for j in i[1]: config.set(i[0], j[0], j[1]) for key, value, comment in keylist: -- To view, visit http://gerrit.ovirt.org/294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8408613487ee5f4a5cd6e79c83fc7178a869abb5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
