Federico Simoncelli has posted comments on this change.
Change subject: Clean up the config.py format
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/config.py.in
Line 238: for j in i[1]: config.set(i[0], j[0], j[1])
It was using a text parser with a regexp to generate the sample config file.
Exposing the keys/defaults/comments in a data structure looked cleaner to me.
Also all those "config.set('vars'" and "config.set('irs'" looked very
repetitive. The lack of comments could be resolved also using something more
descriptive than None (hint for everyone reading this :-).
--
To view, visit http://gerrit.ovirt.org/294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8408613487ee5f4a5cd6e79c83fc7178a869abb5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
