Igor Lvovsky has posted comments on this change. Change subject: Adding renames to Image._baseRawVolumeMerge for robustness. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) .................................................... File vdsm/storage/image.py Line 1018: # Step 1: Create an empty volume named sucessor_volume_TOP sucessor_TOP similar to ancestor volume. Consider TOP -> MERGE Line 1028: # Step 1: Create an empty volume named sucessor_volume_TOP with destination volume's parent parameters sucessor_TOP Line 1060: for v in chList: chList is dict therefore should be v['volUUID'] -- To view, visit http://gerrit.ovirt.org/445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4263f649e1936fcc1ccb7d5c094e9894f02fcd4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
