Dan Kenigsberg has posted comments on this change. Change subject: Adding renames to Image._baseRawVolumeMerge for robustness. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/image.py Line 1029: newUUID = srcVol.volUUID + "_MERGE" this is a serious change in semantics (even if positive!) after a failed merger pg volUUID, not future merges of it can take place. This makes some sense, but justifies a separate patch with a clear, long explanation. -- To view, visit http://gerrit.ovirt.org/445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4263f649e1936fcc1ccb7d5c094e9894f02fcd4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
