Dan Kenigsberg has posted comments on this change. Change subject: BZ#754445 - Seperate granting from callback emitting ......................................................................
Patch Set 6: I would prefer that you didn't submit this (2 inline comments) minor comments about comments, rest seems good, but requires serious Hateyazation. Did you open a ticket? .................................................... Commit Message Line 11: idea how long it will take and what it will do with the resource for /me no English, but please add Period after "the resource", and fix "cruisal". .................................................... File vdsm/storage/resourceManager.py Line 452: # Code in a nested function's body may access but not rebind I suppose that with the replacement of list to Queue, the comment has rotten. -- To view, visit http://gerrit.ovirt.org/254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
