Ayal Baron has posted comments on this change. Change subject: BZ#754445 - Seperate granting from callback emitting ......................................................................
Patch Set 6: I would prefer that you didn't submit this (4 inline comments) .................................................... Commit Message Line 13: On the other hand granting the request has to be synchronious and also fix synchronious Line 14: transactional to prevent races with cancel. To keep both demands I split also, you're repeating yourself (Granting has to happen... On the other hand granting ...) .................................................... File vdsm/storage/resourceManager.py Line 452: # Code in a nested function's body may access but not rebind Actually I don't see the difference between list and queue in this respect so I'm not sure the comment should change. however the apostrophe in wouldn't is after the 'n', not before. Line 470: return resource.get() if for some reason resource queue is empty then the thread would hang here forever. the previous version of the code handled this state -- To view, visit http://gerrit.ovirt.org/254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
