Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add sharedFS constants
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 59: PARAM_VALIDATION_REGISTRAR = {
is "registrar" a fancy name for "dict" ? ;-)
should this be global?
Line 64: # it as is. In the future please prevent this.
...by removing the following line?
--
To view, visit http://gerrit.ovirt.org/559
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea9620f9179b415152d3e32509b5ebe02d8d77b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
