Dan Kenigsberg has posted comments on this change. Change subject: Add SharedFS Support ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/sd.py Line 75: SHAREDFS_DOMAIN: 'SHAREDFS'} blechs* - vm.py needs to know if a domain is file-based, and it does it by checking 'NFS' and 'LOCALFS'. I guess we should add SHAREDFS and CIFS to there, or define isFileBased() here and call it from there. * blechs refers to existing vm.py code, not your new one. -- To view, visit http://gerrit.ovirt.org/559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ea9620f9179b415152d3e32509b5ebe02d8d77b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
