Dan Kenigsberg has posted comments on this change. Change subject: [WIP] Other stuff should be rebased ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... Commit Message Line 7: [WIP] Other stuff should be rebased huh? .................................................... File vdsm/storage/hsm.py Line 1891: newSD = nfsSD.NfsStorageDomain.create(sdUUID, domainName, domClass, I expected that you'd want to rename nfsSD.NfsStorageDomain if you do that, I know how you like renaming! .................................................... File vdsm/storage/storage_connection.py Line 192: if not mnt.isMounted(): is there no fear of connect/connect or connect/disconnect race here? Line 284: # and replaced with stubs. hear hear -- To view, visit http://gerrit.ovirt.org/560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1ad9ac956fe3e4355f7333dbc27978aa515dc9b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
