Saggi Mizrahi has posted comments on this change. Change subject: [WIP] Other stuff should be rebased ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1891: newSD = nfsSD.NfsStorageDomain.create(sdUUID, domainName, domClass, I don't want renaming the file to ruing the diff, maybe in a different patch. I do like renaming though. .................................................... File vdsm/storage/storage_connection.py Line 192: if not mnt.isMounted(): Mounting the same folder twice is actually possible. Even in current code. Should be handled somewhere else. Were also thinking of never mounting in the same place so there wouldn't be a problem. -- To view, visit http://gerrit.ovirt.org/560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1ad9ac956fe3e4355f7333dbc27978aa515dc9b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
