Saggi Mizrahi has posted comments on this change. Change subject: Group the cluster lock code into a new SP method ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) If you don't think my concern should be addressed then it's fine by me. else just fix it and send another patch, .................................................... File vdsm/storage/sp.py Line 70: POOL_TEMPORARY_HOSTID = 250 250 is really, it also might need to be lock implementation dependent. -- To view, visit http://gerrit.ovirt.org/603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
