Igor Lvovsky has posted comments on this change. Change subject: Group the cluster lock code into a new SP method ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/sp.py Line 635: self._acquireTemporaryClusterLock(msdUUID, safeLease) I think you can pass here the master domain object itself 'msd'. You already produced it. In this case you can avoid unnecessary domain producing. I know that it's probably will be done from the cache, but first not always and second Edu works very hard to reduce domain produces in the code. Line 667: self._releaseTemporaryClusterLock(msdUUID) same as above -- To view, visit http://gerrit.ovirt.org/603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
