Igor Lvovsky has posted comments on this change.

Change subject: Remove appendCD. cdrom is now in _drives.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/vm.py
Line 367:         confDrives.append({'device': 'cdrom', 'path': 
self.conf.get('cdrom', ''), 'iface': 'ide', 'index': 2, 'blockDev': False, 
'truesize': 0})
In new libvirt there is no more restrictions for cdrom to be IDE and 'hdc'.
I think that need first to try get the 'iface' and 'index' from self.conf.get() 
and use IDE and hdc only as default

--
To view, visit http://gerrit.ovirt.org/628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccf2857b3febb5b41008c8402c196c5f04b3601
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to