Dan Kenigsberg has posted comments on this change.
Change subject: Remove appendCD. cdrom is now in _drives.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 370: confDrives.append({'device': 'cdrom', 'path':
self.conf.get('cdrom', ''), 'iface': 'ide', 'index': 2, 'blockDev': False,
'truesize': 0})
ELONGLINE
Line 477
this may well be an awkward behaviour, but our client counts on that. If the
cdrom path is missing, go ahead, but drop it from conf.
please maintain it.
--
To view, visit http://gerrit.ovirt.org/628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccf2857b3febb5b41008c8402c196c5f04b3601
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
