Igor Lvovsky has posted comments on this change.
Change subject: Rearange code in storage_connection to minimize code duplication
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/storage_connection.py
Line 119: rc = se.StorageServerConnectionError.code
As I mentioned in pathset 1 (that you ignored). It were different error codes (
StorageServerDisconnectionError, StorageServerConnectionError,
StorageServerValidationError) depends of called function. I don't know whether
it very important but RHEV-M pass this error to the user.
Line 120: self.log.error("Error during storage connection
operation: %s", ex, exc_info=True)
Why 'ex' ?
--
To view, visit http://gerrit.ovirt.org/556
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
