Dan Kenigsberg has posted comments on this change. Change subject: Rearange code in storage_connection to minimize code duplication ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/storage/storage_connection.py Line 275: validateDirAccess(con['rp']) here too, an exception would have been translated to se.StorageServerValidationError.code. now it is translated to se.StorageServerConnectionError.code. Line 327: os.unlink(lnPath) Igor is right: In the former code, an exception here would have caused rc=se.StorageServerDisconnectionError.code, which is not the case now. I'm not sure that the old behavior is necessary, but you are breaking it. -- To view, visit http://gerrit.ovirt.org/556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3e28c064043f19cefccde13decf6699d2718634 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
