Dan Kenigsberg has posted comments on this change.
Change subject: Simplified Drive class.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vm.py
Line 363: drv['iface'] = self.conf.get('if')
no KeyError is expected from dict.get()
p.s I do not remember why 'if' was popped out of conf... seems like a problem
in squashing patches.
--
To view, visit http://gerrit.ovirt.org/625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b33da25e5691910b9d58ecfb727e993991a4c83
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
