Dan Kenigsberg has posted comments on this change.
Change subject: Simplified Drive class.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
very minor
....................................................
File vdsm/vm.py
Line 358: drv['iface'] = self.conf.get('if')
what you do below is achievable by
drv['iface'] = self.conf.get('if', 'ide')
which is shorter and clear imho.
--
To view, visit http://gerrit.ovirt.org/625
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b33da25e5691910b9d58ecfb727e993991a4c83
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
