Federico Simoncelli has posted comments on this change.
Change subject: create /rhev repository
......................................................................
Patch Set 12: (3 inline comments)
It's worthless to review a patch after it is already merged. I hope we won't
repeat these mistakes.
....................................................
File vdsm_cli/Makefile.am
Line 13: dumpStorageTable.py \
You should remove it from here.
....................................................
File vdsm/Makefile.am
Line 79: $(dist_man8_MANS)
All the substituted files should be nodist (we're not distributing the
generated files).
....................................................
File vdsm.spec.in
Line 259: mkdir -p %{buildroot}@vdsmrepo@
This should go in the Makefile.am
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
