Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] create /rhev repository
......................................................................
Patch Set 9: (3 inline comments)
feel free to drop the [WIP] prefix if the run-vm-twice bug is reproducible
before this patch.
....................................................
File vdsm/storage/fileSD.py.in
Line 51: sdUUID = metaList.index('data-center') + sdUUIDPos
see fileVolume comment.
sorry I was not clean in my former review.
....................................................
File vdsm/storage/fileVolume.py.in
Line 42: sdUUID = volList.index('data-center') + sdUUIDPos
hard coding 'data-center' here is not a good idea.
all you really need is len(normpath(config.get('irs',
'repository')).split('/')) + 2 or something line this.
as I said earlier, I think that this can be done during runtime/importtime and
there is no need for autoconfing here.
....................................................
File vdsm/vdsm.rwtab.in
Line 3: empty @VDSMREPO@
a tab char?! the horror.
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
