Dan Kenigsberg has posted comments on this change. Change subject: Change device ownership for VM's drives. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (3 inline comments) where's the rule removal (on vm.destroy) .................................................... File vdsm/clientIF.py Line 569: def _prepareVolumePath(self, drive, vmId = None): no space in arg=defaultVal .................................................... File vdsm/storage/hsm.py Line 2406: rule = 'SYMLINK=="mapper/%s", OWNER="vdsm", GROUP="qemu"\n' % guid vdsm/qemu should be taken from constants. Line 2411: supervdsm.getProxy().udevTrigger(guid) how about exposing only supervdsm.addUdevRule() -- To view, visit http://gerrit.ovirt.org/904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7859635b8abed67fe006886efd500eb9ac9f3b7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
