Dan Kenigsberg has posted comments on this change. Change subject: Change device ownership for VM's drives. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 2408: rc, out = misc.writefileSUDO(ruleFile, rule) writefileSUDO is an evil function that lets a buggy vdsm do anything on the host. supervdsm should expose an interface which is as secure as possible. in this case: add a rule, remove (a) rule(s), and if you insist - trigger udev. -- To view, visit http://gerrit.ovirt.org/904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7859635b8abed67fe006886efd500eb9ac9f3b7c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
