Adam Litke has posted comments on this change.
Change subject: Move API out of clientIF
......................................................................
Patch Set 1: (6 inline comments)
Ewoud, thank you for your review and comments. Whitespace issues have been
fixed.
....................................................
File vdsm/API.py
Line 267: self._cif.vmContainerLock.acquire()
Good suggestion, but this patch is just moving the implementation from one
place to another. I would prefer not to make functional changes to the code at
the same time.
Line 300: return {'status': doneCode, 'statsList': [stats]}
Done
Line 470:
Done
Line 1192: options[_translationMap[k]] = options.pop(k)
Done
....................................................
File vdsm/bindingXMLRPC.py
Line 312:
Done
Line 465:
Done
--
To view, visit http://gerrit.ovirt.org/985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ad036cfaf3d1bec2f5b4049979a1bf0e2810ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
