Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Move API out of clientIF
......................................................................
Patch Set 1: (6 inline comments)
Mostly whitespace related.
I only once suggested to use with self._cif_vmContainerLock, but that could be
used more often.
....................................................
File vdsm/API.py
Line 267: self._cif.vmContainerLock.acquire()
Perhaps you could use the with statement:
with self._cif.vmContainerLock:
self.log.info("vmContainerLock acquired by vm %s", self._UUID)
v = self._cif.vmContainer.get(self._UUID)
It's the same as using the try-finally-release, unless self.log.info throws an
exception. Also easier on the eyes imho.
Line 300: return {'status': doneCode, 'statsList': [stats]}
Please remove the trailing whitespace
Line 470:
Please remove the trailing whitespace
Line 1192: options[_translationMap[k]] = options.pop(k)
Please remove the trailing whitespace
....................................................
File vdsm/bindingXMLRPC.py
Line 312:
Please remove trailing whitespace
Line 465:
Please remove trailing whitespace
--
To view, visit http://gerrit.ovirt.org/985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94ad036cfaf3d1bec2f5b4049979a1bf0e2810ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
