Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Add an object model to clientIF ......................................................................
Patch Set 1: (7 inline comments) Relative small suggestions. .................................................... File vdsm/API.py Line 27: class VM(object): Please remove the trailing whitespace Line 43: return self._cif.create(createParameters) I wouldn't modify the original dict, but work on a copy obtained by dict.copy(). Line 72: return self._cif.migrate(params) Same here about dict.copy() Line 78: params['vmId'] = self._UUID Same here about dict.copy() Line 373: Please remove the trailing whitespace Line 406: # This internal API deviates horribly in that it takes a Please remove the trailing whitespace Line 408: _vmString = string.join(vmList, ',') string.join() is deprecated. Please use ','.join(vmList). -- To view, visit http://gerrit.ovirt.org/984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee54277c87a02ac8dafe29a8761e2acf0f7397f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
